Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store enumValue.name in enumValueName (not enumValue.toString()) #102

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

IlyaMuravjov
Copy link
Collaborator

enumValue.toString() is not necessarily an invective function, so using it to build descriptors is unsafe. Furthermore, the name of the enumValueName property suggests that enumValue.name is stored in it, but unexpectedly enumValue.toString() is stored in enumValueName.

@DaniilStepanov DaniilStepanov merged commit 4c77f96 into main Dec 27, 2024
1 check passed
@DaniilStepanov DaniilStepanov deleted the ilya_m/enum_value_name branch December 27, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants